Skip to content

Release v1.5.6 #975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AmandaRiu merged 12 commits into from
Apr 14, 2022
Merged

Release v1.5.6 #975

AmandaRiu merged 12 commits into from
Apr 14, 2022

Conversation

@planarvoid
Copy link
Contributor

@planarvoid planarvoid commented Apr 5, 2022 •
edited
Loading

This branch is used to test the changes made to Aztec editor in other repositories. It contains no changes to the logic, just the README update. To test it target:
975-e69dca965397a9f2978c8722976bee2f9de597ba as the aztec version.

Review

@AmandaRiu
@hypest

Make sure strings will be translated:

  • If there are new strings that have to be translated, I have added them to the client's strings.xml as a part of the integration PR.

@planarvoid planarvoid requested review from AmandaRiu and hypest April 5, 2022 13:09
@planarvoid planarvoid self-assigned this Apr 5, 2022
@hypest
Copy link
Contributor

hypest commented Apr 6, 2022

Unfortunately, I won't have today to attend to this PR so, perhaps @mchowning you can join instead? @planarvoid also had let me know (via Slack) that this is ready to be tested from the gutenberg-mobile side and would like help with creating the gb-mobile and/or Gutenberg PRs to point to this one.

@planarvoid planarvoid requested review from mchowning and removed request for hypest April 6, 2022 10:52
@mchowning mchowning mentioned this pull request Apr 6, 2022
Merged
@mchowning
Copy link
Contributor

mchowning commented Apr 6, 2022

I've created Gutenberg and Android PRs with this change. The WPAndroid PR has builds for testing. I did a bit of testing and didn't see any issues.

@AmandaRiu
Copy link
Contributor

AmandaRiu commented Apr 7, 2022

Will wait till this PR is merged before testing this PR. @planarvoid please let me know when it's ready 👍🏻

planarvoid and others added 6 commits April 8, 2022 12:17
@planarvoid
Copy link
Contributor Author

planarvoid commented Apr 14, 2022 •
edited
Loading

I think this is ready for review/merge @AmandaRiu @mchowning . The version number will actually be v1.5.7 but I'll add that tag only once this is merged. I've added the v1.5.6 tag too early and it doesn't include all the changes now.

AmandaRiu
AmandaRiu approved these changes Apr 14, 2022
View reviewed changes
Copy link
Contributor

@AmandaRiu AmandaRiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@AmandaRiu
Copy link
Contributor

AmandaRiu commented Apr 14, 2022

This is approved, but unable to merge due to CI failures. Attempting to rerun.

@AmandaRiu
Copy link
Contributor

AmandaRiu commented Apr 14, 2022

Ah, the build is failing for CI on the step to publish to S3 because 1.5.6 is already published to S3. Going to do a forced merge.

@AmandaRiu AmandaRiu merged commit 41a0bc2 into trunk Apr 14, 2022
@AmandaRiu AmandaRiu deleted the release/1.5.6 branch April 14, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mchowning mchowning Awaiting requested review from mchowning

1 more reviewer

@AmandaRiu AmandaRiu AmandaRiu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@planarvoid planarvoid

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@planarvoid @hypest @mchowning @AmandaRiu